]> dgit.raspbian.org Git - gnome-shell.git/commit
St: Ensure to update entry hint visibility with IM preedit
authorCarlos Garnacho <carlosg@gnome.org>
Wed, 11 Mar 2020 11:32:07 +0000 (12:32 +0100)
committerCarlos Garnacho <carlosg@gnome.org>
Wed, 11 Mar 2020 13:07:07 +0000 (14:07 +0100)
commitb18469427e5c19402111de5fe9888bceec0eaacd
treecc5685149563901e539607e8f418f55fc48e658a
parent72c4f148ef88b4bffb2106b99434da5c05c0bb64
St: Ensure to update entry hint visibility with IM preedit

Commit 88ac339774 changed StEntry behavior so the text hint would
stay visible while focused, as long as the text buffer is empty.
However, IMs that use preedit still should count as "started typing",
while the text buffer is still officially empty.

To fix this, check on st_entry_update_hint_visibility() that there's
indeed no preedit buffer before showing the hint. We can't directly
listen to internal preedit buffer changes in ClutterText, so handle
preedit buffer updates through the ::cursor-changed signal that will
be indirectly emitted.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1084
src/st/st-entry.c